Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for array of Struct and array of NestedStruct #111

Merged
merged 16 commits into from
Jun 10, 2024
Merged

add support for array of Struct and array of NestedStruct #111

merged 16 commits into from
Jun 10, 2024

Conversation

dpaiton
Copy link
Member

@dpaiton dpaiton commented Jun 9, 2024 •
edited
Loading

@codecov-commenter
Copy link

codecov-commenter commented Jun 9, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 37.65690% with 149 lines in your changes missing coverage. Please review.

Project coverage is 64.32%. Comparing base (46e0682) to head (0fc544d).

Files Patch % Lines
pypechain/test/errors/types/utilities.py 17.85% 23 Missing ⚠️
pypechain/test/events/types/utilities.py 17.85% 23 Missing ⚠️
pypechain/test/overloading/types/utilities.py 17.85% 23 Missing ⚠️
pypechain/test/structs/types/utilities.py 17.85% 23 Missing ⚠️
pypechain/test/deployment/types/utilities.py 21.42% 22 Missing ⚠️
pypechain/templates/utilities.py 36.84% 12 Missing ⚠️
pypechain/utilities/abi.py 25.00% 9 Missing ⚠️
pypechain/test/return_types/types/utilities.py 71.42% 8 Missing ⚠️
pypechain/utilities/types.py 0.00% 4 Missing ⚠️
pypechain/main.py 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #111      +/-   ##
==========================================
- Coverage   67.34%   64.32%   -3.03%     
==========================================
  Files          49       49              
  Lines        2346     2531     +185     
==========================================
+ Hits         1580     1628      +48     
- Misses        766      903     +137
Flag Coverage Δ
unittests 64.32% <37.65%> (-3.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dpaiton dpaiton force-pushed the slundquist-vec-of-struct branch from 8f5518c to 83c723a Compare June 9, 2024 17:56
@dpaiton dpaiton requested a review from sentilesdal June 10, 2024 15:52
sentilesdal
sentilesdal approved these changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@sentilesdal sentilesdal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm if tests are passing

@dpaiton dpaiton force-pushed the slundquist-vec-of-struct branch from df54704 to 39f531b Compare June 10, 2024 22:20
@dpaiton dpaiton force-pushed the slundquist-vec-of-struct branch from 39f531b to 0b20670 Compare June 10, 2024 22:24
@dpaiton dpaiton merged commit 024ffde into main Jun 10, 2024
6 checks passed
@dpaiton dpaiton deleted the slundquist-vec-of-struct branch June 10, 2024 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sentilesdal sentilesdal sentilesdal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dpaiton @codecov-commenter @sentilesdal @slundqui